3MFConsortium / test_suites

This repository contains 3MF conformance test suites. Each test suite provides coverage for a specific combination of 3MF Core and Extension requirements.
BSD 2-Clause "Simplified" License
7 stars 0 forks source link

Missing test case for defined pid but not property indexes #65

Closed jordig100 closed 3 years ago

jordig100 commented 4 years ago

Test "P_???_0502 Triangle P1, 2, 3 Usage" does not cover the case where pid is defined but no p1 is defined. The expected result is to apply the default object property.

JimZuber commented 4 years ago

To clarify, we need to add the following test cases for triangles, beamlattice, beams, and Balls as follows:

pid present, no index (i.e. p1) - use default index present, no pid. - index applied to default pid

The existing test cases for triangles, beamlattice, and beams have BOTH pid and the index present in override test cases.

JimZuber commented 3 years ago

-Test Specification was updated to add tests for this functionality. -Test case P_???_031201 was updated to test missing functionality described in this issue on suites 1, 3, 4, and 5 -Test case P???_0506_01 was updated to test missing functionality described in this issue on suites 2 and 6 -Expected thumbnail albums updated for suites 1 to 6