Added create, read, update use cases for interview questions

3PillarGlobal-Czechia / interview-app-api

API for Interview App.

MIT License

3 stars 1 forks source link

Added create, read, update use cases for interview questions #11

Closed TomasNiemczyk98 closed 2 years ago

TomasNiemczyk98 commented 2 years ago

Summary

Added create, read, update use cases for interview questions

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Refactoring (non-breaking change to code and structure)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

PlesnikJakub commented 2 years ago

There are two areas that can be enhanced to perfection

Since we use mocks I am not sure if we should preserve default presenters OR we should implement them in a way that it's done for example in clean architecture manga and use that presenter in tests.

https://github.com/ivanpaulovich/clean-architecture-manga/blob/main/accounts-api/src/Application/UseCases/Deposit/DepositPresenter.cs

The second area is the E2E tests that are missing 😱😄 Look into src\WebApi\End2endTests\Tests\GetUserTests.cs for example and make same trivial calls for other endpoints.

PlesnikJakub commented 2 years ago

@petrspelos help wanted, especially about presenters.

PlesnikJakub commented 2 years ago

I have updated code coverage computation so it passes now but let's wait for a comment from @petrspelos on the topic of presenters other than that it looks good 😊

PlesnikJakub commented 2 years ago

@TomasNiemczyk98 since Peter did not respond let's go forward with the merge and create a separate issue as a question for Peter. Can you take care of writing it down? 🤔

Good Work 🚀

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

85.3% Coverage
0.0% Duplication