search

3PillarGlobal-Czechia / interview-app-api

API for Interview App.
MIT License
3 stars 1 forks source link

Remove condition #45

Closed TerezaSkutova closed 2 years ago

TerezaSkutova commented 2 years ago

We don't have a reverse proxy so far, which means only the option currently in the first block of the condition should be used.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

petrspelos commented 2 years ago

Also, @TerezaSkutova you might want to edit your git name to be tagged as this GitHub account.

(also probably your git email to "TerezaSkutova@users.noreply.github.com" )

You can do this in your favorite git GUI.

or...

[Click to expand] How to change name in git cli (advice nobody asked for): 😅 Run in your favorite terminal: ``` git config --global user.name TerezaSkutova git config --global user.email TerezaSkutova@users.noreply.github.com ``` > 💡 optionally leave out `--global` but then you'd have to run it from the repository's directory

Otherwise we'll have two of you here. And that would of course mean you'd have to do twice as much work. 😏 As much as our PO @PlesnikJakub would like that, we should avoid it. 😅

EDIT: You can also amend the existing commit to change the author.

in the cli it's

git commit --amend --author="TerezaSkutova<TerezaSkutova@users.noreply.github.com>"