Technical debt/GitHub warnings

[TomasNiemczyk98]

Summary

Fixing github warning shown with every pull requests. One waning cannot be fixed in code and that is Configuring loggers is security-sensitive. The rule basically says that we should double check to make sure our logger configuration is correct and we are logging correct stuff in case of a potential attack on the system.

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [X] Refactoring (non-breaking change to code and structure)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

[TomasNiemczyk98]

There is low coverage due to class DomainException not being currently used and I cannot write any dummy test for it since it's meant as an abstract class, any idea how to proceed?

[petrspelos]

@TomasNiemczyk98, I believe you should still be able to write a mock implementation of it in your tests. 🤔

While this isn't really testing anything, I think it is safer than adding ignore rules to the coverage reporting.

I'd suggest something like a TestDomainException : DomainException and throw it a couple of times in a test.

What do you guys think?

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

80.0% Coverage
0.0% Duplication