Improvement: File scoped namespaces as default

3PillarGlobal-Czechia / interview-app-api

API for Interview App.

MIT License

3 stars 1 forks source link

Improvement: File scoped namespaces as default #82

Closed TomasNiemczyk98 closed 2 years ago

TomasNiemczyk98 commented 2 years ago

Description

Since we are trying to enforce file scoped namespaces in the entire app we could try setting them as default. This can be done in .editorconfig file like this:

[*.cs] csharp_style_namespace_declarations=file_scoped:warning

However there is currently a minor bug that's apparently fixed but not yet delivered in current visual studio 2022 version.

Do we make the change now or wait until it's fixed?

petrspelos commented 2 years ago

I'd still go for it, it's not like we won't notice, it straight up won't compile.

I sent @PlesnikJakub a draft of an .editorconfig that does include that rule.

PlesnikJakub commented 2 years ago

It seems we have thin included in the latest .editorconfig. Kudos to @petrspelos and I am closing this issue.