3PillarGlobal-Czechia / interview-app-api

API for Interview App.
MIT License
3 stars 1 forks source link

Add Code Standrads through .editorconfig #86

Closed petrspelos closed 2 years ago

petrspelos commented 2 years ago

Summary

Added a .editorconfig file with specific rules for .NET and C#. Some of these rules are fairly strict and will require either softening through setting the severity to suggestion or deletion altogether.

@ maintainers, feel free to commit changed into this PR.

We should hopefully see the warnings introduced in the CI/CD pipeline, if not, feel free to checkout and build the branch. By default, these warnings should show in your Visual Studio Output window (or CLI for the first build). Some are suggestions and will be only visible in the appropriate files through the IDE.

Types of changes

Notes

The .editorconfig should be annotated, so feel free to search for a specific warning by what it actually says. You can also search by the Code (ie. CA1716)

Co-assigning @PlesnikJakub since we discussed some of these changes together. ☺️

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

petrspelos commented 2 years ago

I've also noticed some of these diagnostic warnings are only showing in IDEs, so be mindful of that. 👍 🙌

TomasNiemczyk98 commented 2 years ago

Looks good to me, also this could probably also be included in the Web API template @PlesnikJakub ?

petrspelos commented 2 years ago

Looks good to me, also this could probably also be included in the Web API template @PlesnikJakub ?

+1, though of course changed according to your preferences