TomasNiemczyk98
commented
2 years ago Looking at the reason the pipeline is failing and it's due to a test that is not passing, the test is in End2EndTests/QuestionTests/UpdateQuestionTest, the test basically tries to change the difficulty of a question to some invalid value (previously this was 6), now this test will probably have to be changed a little bit since the validation is now performed on the controller.
[Fact]
public async Task Update_InvalidRequest_ReturnsBadRequest()
{
var request = new UpdateQuestionRequest
{
Difficulty = 6
};
var result = await EndpointCall(1, request);
Assert.Equal(HttpStatusCode.BadRequest, result.StatusCode);
}
Ali-Kabbadj
petrspelos
PlesnikJakub
Added the necessary validation attributes to the Difficulty property
Summary
Added [Range] and [Required] attributes to the Difficulty properly in : *CreateQuestionRequest
Added [Range] attributes to the Difficulty properly in : *UpdateQuuestionRequest
Added a custume Validation Attribute to the Difficulties properly in : *GetQuestionRequest
Note: For Difficulties properly in GetQuesttionRequest , i added an extension to the ValidationAtribute Class to be able to validate the range of an IEnumerable< int > Difficulties
Types of changes
Notes
I was wondering if the custume validation for IEnumerable Difficulties should maybe return all the questions for the difficulties that were correct, and just ignore the out of range ones, instead of what my implementation does ,which is return an error if one of the values in the IEnumerable is out oof range.
Also , for some reason when updating a question ,if one of the values is not provided in the put request the value is set to null , i was wondering is that was by choice .
If there is anything to change or modify just let me know , thanks in advance!