fix: null value at first visit

3Shain / Comen

📺直播用弹幕栏【原bilichat】

https://comen.app

MIT License

908 stars 83 forks source link

Closed lonelyion closed 3 years ago

lonelyion commented 3 years ago

PR了一个有bug的代码我紫菜（

这样应该好了

3Shain commented 3 years ago

草我还以为你跑过了。我看这块是同步的，改成inline函数罢

roomId = new FormControl(()=> localStorage.getItem('roomId')?.trim() ?? '123456');

草改了四次

lonelyion commented 3 years ago

可能是热加载，然后我就以为完全重载了，就没想到一开始是空的（

lonelyion commented 3 years ago

绝了，今天可能不适合写代码

lonelyion commented 3 years ago

更离谱了啊喂

回滚到 3f02f8c9a229429274e7bd5cbe5afc2e04a3ea4c 算了吧（逃

3Shain commented 3 years ago

尼玛，今天确实不适合写代码麻烦加几个括号

lonelyion commented 3 years ago

等下，要不今天代码revert一下（

我还想到了A/B站的选项也应该存下来

3Shain commented 3 years ago

回退了，重来