Finish the core data operation if saving errors

3Squared / SQKDataKit

Lightweight Core Data helper to reduce boilerplate code.

MIT License

19 stars 6 forks source link

Finish the core data operation if saving errors #62

Closed lukestringer90 closed 9 years ago

lukestringer90 commented 9 years ago

This addresses issue #62. However there is a problem:

The changes to SQKCoreDataOperationTests now cause the testInitialisingWithObjectAsync test in SQKManagedObjectControllerTests to hang. If the implementation of performWorkWithPrivateContext: of the ConcreteDataImportOperation class is removed then test suite finishes. However this then means that the testFinishesWhenSavingErrors test (which is reliant on this method implementation) fails.

blork commented 9 years ago

😪 Maybe it's worth rethinking the architecture now the new Core Data guide is out, 'cause we've had these hangs before.