3UTR / DaPars2

Dynamics analysis of Alternative PolyAdenylation from RNA-seq
GNU General Public License v2.0
50 stars 23 forks source link

Why is DaPars2_Multi_Sample_Multi_Chr.py hardcoded for human genome? #14

Closed dzhaobio closed 2 years ago

dzhaobio commented 2 years ago

Does the method only apply to human data?

I tried it on mouse data. I constantly ran into errors. Finally I found the variable "All_chroms" was hard-coded to human genome.

lines 112-118 in DaPars2_Multi_Sample_Multi_Chr.py

    All_chroms = []
    All_chroms.append('chrX')
    All_chroms.append('chrY')

    for i in range(22):
        curr_chr = 'chr%i' % (i+1)
        All_chroms.append(curr_chr)

If this method is not limited to human genome, the code should be fixed to make it work for general genomes. The authors should not assume how the chromosomes are named. For example, there is not always "chr" in chromosome names. The chromosome names should be obtained from the data provided. If it does not work for general genomes, it will definitely make users frustrated.

3UTR commented 2 years ago

Hi dzhaobio,

Curent code only apply to human data, but we will update to make it more general.

Thanks.