search

3YOURMIND / django-add-default-value

This django Migration Operation can be used to transfer a Fields default value to the database scheme.
Apache License 2.0
138 stars 20 forks source link

Add Django 2.1 to supported versions #6

Closed David-Wobrock closed 5 years ago

David-Wobrock commented 5 years ago

Fixes #5 I see nothing against supporting Django 2.1

A pity there are no tests at all yet

igeligel commented 5 years ago

Is there a wildcard to use all 2.y.z versions? Django after 2.0 is following semantic versioning so this plugin should work with all versions of django following the 2.y.z version.

David-Wobrock commented 5 years ago

It is possible to have just Django>=1.10, without upper boundary - but we cannot guarantee that all Django 2 versions will function. There might be a core change on the migrations/operations in a later Django 2 version which we cannot foresee. And once tests will be implemented, we should gradually add new Django versions I guess

igeligel commented 5 years ago

This is exactly why Django switched to semantic versioning. To make sure that minor and patch versions do not break: https://semver.org/ Those versions just introduce new methods to existing public interfaces and bug fixes/improvements to current versions. If we never trust any other software vendor we should build everything ourself...

David-Wobrock commented 5 years ago

I understand your point, but this is not about trusting the DSF or not. In an ideal world, no mistake would happen and no API is broken in a minor version. However, since humans seem to make mistakes from time to time, let's be safe and increase the versions as they come. The cost of adding a new Django version to the dependencies and to the test matrix here is minimal, and this library will therefore always support what it has been tested against.

That would be my suggestion, since it is also the standard way of handling new versions in other Django libraries.

David-Wobrock commented 5 years ago

@mes3yd Done :heavy_check_mark: - dropped Django 1.10 Even though I would have kept it while it didn't need any additional effort to maintain it

unknownlighter commented 5 years ago

is there any progress for merging this PR and release new version to pypi?

David-Wobrock commented 5 years ago

I guess #8 should be preferred, since this PR brings no value to the project

ghost commented 5 years ago

This has been addressed in different PR.