3akev / godot-arabic-text

MIT License
22 stars 7 forks source link

Correctly ported some methods to their gdscript equivalents #5

Closed noidexe closed 4 years ago

noidexe commented 4 years ago

More complex text (e.g: https://r12a.github.io/scripts/tutorial/summaries/arabic ) was failing due to part of the code using methods present in python but not in gdscript

Notably: Python GDScript
my_list.extend(other_list) my_array += other_array
List.pop() Array.pop_back()
my_list.pop(idx) my_list[idx]; my_list.remove(idx)
a,b = some_array.pop() var tmp = some_array.pop(); a = tmp[0]; b= tmp[1]
a == b == "some string" a == b and b == "some string"

Known issues:

3akev commented 4 years ago

LGTM, and sorry for taking so long!