[x] I have requested a review from the appropriate persons
[x] I have checked that my changes work in the preview
[x] I have checked that the rest of the site is still functioning in the preview
[x] I have checked that my content/code is consistent with existing content/code
[x] I have used components in the places and ways they are intended (see the readme)
[x] I have formatted all of my code with Prettier
Fixes #369
Moved some dependencies which were in dependencies to devdependencies to prevent them clogging up the dependencies list since they are not needed in production
Ran yarn format which purely formats code and nothing else (no harm to code logic), affects majority of the files in this pull request
Created new command called yarn lint which allows devs to run eslint in console
Both yarn lint and yarn format are implemented in a Github Actions workflow to run on every PR to ensure that devs are following correct formatting and EsLint
Ran linting throughout the repo and fixed as many issues I could without significantly changing things
Much of the changes with EsLint consisted of changes with == vs ===, != vs !== and unused variables/imports
There are still some errors/warnings to be fixed, which hopefully someone more knowledge about the codebase can tackle, I have pasted the report below:
Once these errors are removed, then if desired an admin of the repo can enable branch protection rules with the status checks to ensure that formatting and linting pass before a developer can merge their code
[x] I have requested a review from the appropriate persons
[x] I have checked that my changes work in the preview
[x] I have checked that the rest of the site is still functioning in the preview
[x] I have checked that my content/code is consistent with existing content/code
[x] I have used components in the places and ways they are intended (see the readme)
[x] I have formatted all of my code with Prettier
Fixes #369
Moved some dependencies which were in
dependenciestodevdependenciesto prevent them clogging up thedependencieslist since they are not needed in productionRan
yarn formatwhich purely formats code and nothing else (no harm to code logic), affects majority of the files in this pull requestCreated new command called
yarn lintwhich allows devs to run eslint in consoleBoth
yarn lintandyarn formatare implemented in a Github Actions workflow to run on every PR to ensure that devs are following correct formatting and EsLintRan linting throughout the repo and fixed as many issues I could without significantly changing things
Much of the changes with EsLint consisted of changes with
==vs===,!=vs!==and unused variables/importsThere are still some errors/warnings to be fixed, which hopefully someone more knowledge about the codebase can tackle, I have pasted the report below:
https://github.com/3b1b/3Blue1Brown.com/actions/runs/7245820114/job/19736572822?pr=370
Once these errors are removed, then if desired an admin of the repo can enable branch protection rules with the status checks to ensure that formatting and linting pass before a developer can merge their code