3box / 3box-dapp

3Box Hub App: User profiles and storage drive
https://3box.io/hub
MIT License
40 stars 28 forks source link

Move to paginated calls for Activity Feed #584

Open oznekenzo opened 4 years ago

oznekenzo commented 4 years ago

This would require either updating the 3box activity library to use a different api from that of etherscan, waiting for etherscan to update their api, or bypassing the 3box activity library and using another api (alethio)

michaelsena commented 4 years ago

@oznekenzo it might make sense to move to Alethio for this, I think. I haven't researched all that many options, but their API seems good and performant based on very limited knowledge. Maybe the first step here is to do research on available solutions then implement the one that makes the most sense.

oznekenzo commented 4 years ago

Update on this: Alethio has three different endpoints for Txs, Internal, & Token transfers, requiring three different paginated calls (by # of transactions), so the very same people that were implementing this feature for (users with high # of transactions) are going to potentially run up against the confusing case where they'll get 50 Txs from yesterday (where 50 is the pagination cursor we decide to use) and 6 Internal transfers from over the course of two years, and in the next call (after scrolling to bottom), the user will get another 50 new Txs in the feed, though now appearing before the 6 internal transfers that were in the feed on the original call. We can work around this by doing multiple calls but we'd be making ~6+ paid api requests instead of 3 (or even 1). I emailed Lucian about somehow providing an aggregated endpoint where we don't have to sort all transactions ourselves, have yet to hear back