search

3box / 3box-graphql

3box GraphQL Service
9 stars 0 forks source link

change the endpoint route to accomodate with the naming scheme #14

Closed c-castillo closed 5 years ago

oed commented 5 years ago

@c-castillo is this deployed? It seems like it would break the current library. we need the endpoint to be availible at 'https://aic67onptg.execute-api.us-west-2.amazonaws.com/develop/graphql' as well going forward not to break past libraries!

c-castillo commented 5 years ago

@oed The endpoint is automatically generated by aws. The new name is just a shortcut to that endpoint so we are good.

oed commented 5 years ago

@c-castillo with this update though the url would become 'https://aic67onptg.execute-api.us-west-2.amazonaws.com/develop/' right though since we removed the /graphql?

c-castillo commented 5 years ago

@oed yes, that's the only part that changes.

c-castillo commented 5 years ago

@oed Since it's not deployed yet, there's still time to update the lib without any breaking changes.

oed commented 5 years ago

@c-castillo if it changes it will break the already released library. We need to make it available on both with and without /graphql

oed commented 5 years ago

Fixed by #15