search

3box / 3id-connect

3ID account management application run in an iFrame
Other
26 stars 6 forks source link

Warning on compilation - production build fails #86

Closed 0xTimepunk closed 3 years ago

0xTimepunk commented 3 years ago

HI, I get this error

image

Using "3id-connect": "1.0.0-alpha.3"

How can it be solved so I can create a production build?

Error in Netlify

image

Thanks

ukstv commented 3 years ago

Hey, @j-mars mind posting here a command you use to summon these warnings/errors?

0xTimepunk commented 3 years ago

Hey, @j-mars mind posting here a command you use to summon these warnings/errors?

Hi,

I created a test repo with basic Create-React-App with latest React 17 so you can just do yarn and yarn start to check the issue

https://github.com/j-mars/3id-connect-test

The warning appears after building in dev mode and then if you want to go to production mode, yarn build fails.

Let me know if I should add extra details to this setup.

ukstv commented 3 years ago

Thanks @j-mars this feels enough for me to figure a proper mitigation.

0xTimepunk commented 3 years ago

Thanks @j-mars this feels enough for me to figure a proper mitigation.

Thanks for your help

I added a setup with redux and redux-saga to simulate a connection to Ethereum / Ceramic / Skynet.

If there's an error when building because of jest just add a Skip Preflight Check to a .env file

ukstv commented 3 years ago

@j-mars Warning is (almost) ok. To unblock you, please, set CI variable to something not true. https://community.netlify.com/t/new-ci-true-build-configuration-treating-warnings-as-errors-because-process-env-ci-true/14434 Default value CI=true turns warnings into errors.

0xTimepunk commented 3 years ago

@j-mars Warning is (almost) ok. To unblock you, please, set CI variable to something not true. https://community.netlify.com/t/new-ci-true-build-configuration-treating-warnings-as-errors-because-process-env-ci-true/14434 Default value CI=true turns warnings into errors.

Hi @ukstv thank you, I will apply that remedy for now!

ukstv commented 3 years ago

Hey, @j-mars while the issue is effectively resolved by disabling Filecoin linking, there is work to do (https://github.com/ceramicstudio/3id-connect/issues/19) to re-enable this in upstream 3id-connect.

So, I am closing this issue with an invitation to follow https://github.com/ceramicstudio/3id-connect/issues/19 if you wish.