3commas-io / 3commas-official-api-docs

Official Documentation for the 3commas APIs
https://3commas.io
247 stars 87 forks source link

Websocket ping, shuold we pong? #130

Closed tur-nr closed 2 years ago

tur-nr commented 2 years ago

Hey just checking that as we try and maintain a stable connection to a Websocket we don't need to send a pong message to 3 Commas. I notice that the server sends a message { "type": "ping", "message": 123456789 } to the client but this is not in compliance with RFC 6455.

Are we supposed to send back a custom pong message to 3 Commas? As you can see from below it's extremely difficult to hold a connection. I know 1006 is that the connection ended abruptly, just trying to work out why as our sockets to exchanges maintain connection either by a custom pong or RFC 6455 pong frames.

$ npx wscat -P -c wss://ws.3commas.io/websocket

Connected (press CTRL+C to quit)
< {"type":"welcome"}
< {"type":"ping","message":1643252983}
< {"type":"ping","message":1643252986}
< {"type":"ping","message":1643252989}
< {"type":"ping","message":1643252992}
< {"type":"ping","message":1643252995}
< {"type":"ping","message":1643252998}
> {"identifier":"{\"channel\":\"DealsChannel\",\"users\":[{\"api_key\":\"*****\",\"signature\":\"*****\"}]}","command":"subscribe"}
< {"identifier":"{\"channel\":\"DealsChannel\",\"users\":[{\"api_key\":\"*****\",\"signature\":\"*****\"}]}","type":"confirm_subscription"}
< {"type":"ping","message":1643253001}
< {"type":"ping","message":1643253004}
< {"type":"ping","message":1643253007}
< {"type":"ping","message":1643253010}
< {"type":"ping","message":1643253013}
< {"type":"ping","message":1643253016}
< {"type":"ping","message":1643253019}
< {"type":"ping","message":1643253022}
< {"type":"ping","message":1643253025}
< {"type":"ping","message":1643253028}
< {"type":"ping","message":1643253031}
< {"type":"ping","message":1643253034}
< {"type":"ping","message":1643253037}
< {"type":"ping","message":1643253040}
< {"type":"ping","message":1643253043}
< {"type":"ping","message":1643253046}
< {"type":"ping","message":1643253049}
< {"type":"ping","message":1643253052}
< {"type":"ping","message":1643253055}
< {"type":"ping","message":1643253058}
< {"type":"ping","message":1643253061}
< {"type":"ping","message":1643253064}
< {"type":"ping","message":1643253067}
< {"type":"ping","message":1643253070}
< {"type":"ping","message":1643253073}
< {"type":"ping","message":1643253076}
< {"type":"ping","message":1643253079}
< {"type":"ping","message":1643253082}
< {"type":"ping","message":1643253085}
< {"type":"ping","message":1643253088}
< {"type":"ping","message":1643253091}
< {"type":"ping","message":1643253094}
< {"type":"ping","message":1643253097}
< {"type":"ping","message":1643253100}
< {"type":"ping","message":1643253103}
< {"type":"ping","message":1643253106}
< {"type":"ping","message":1643253109}
< {"type":"ping","message":1643253112}
< {"type":"ping","message":1643253115}
< {"type":"ping","message":1643253118}
< {"type":"ping","message":1643253121}
< {"type":"ping","message":1643253124}
< {"type":"ping","message":1643253127}
Disconnected (code: 1006, reason: "")
EfremovEvgeniy commented 2 years ago

Hi, now we have in progress new flow with receiving updates by websocket. Problems with connection will be fixed.