search

3d-dice / dice-box

3D Game Dice for any JavaScript App
https://fantasticdice.games/
MIT License
137 stars 30 forks source link

Missing theme.config.json for default theme #105

Closed Steeven9 closed 4 months ago

Steeven9 commented 4 months ago

I just updated my library version to the latest one and there seems to be a breaking change: now also the default theme expects a theme.config.json file, even if the library doesn't provide one:

The getting started page also doesn't mention anything about this new requirement.

Version: 1.0.15 (which doesn't seem to be on GitHub?)

Steeven9 commented 4 months ago

Update: even when trying to copy a config file from another theme such as this one, I still get an error:

image

frankieali commented 4 months ago

Thanks for reporting this. I'll look into it ASAP. I've been making some minor changes in preparations for v1.1.0 but I must have introduced something that wasn't well tested yet. The default config should not be required in the latest version. Which version did you update from? That might help me track down when the bug was introduced.

frankieali commented 4 months ago

Oh no. Looks like code from the forthcoming v1.1.0 made it into v1.0.15. I'll have to revert that out. The docs for v1.1.0 are not ready yet.

Steeven9 commented 4 months ago

Oh, that's good - I thought it was somewhat weird when I saw that 1.0.15 was not here on GitHub yet :D

1.0.14 works as before btw

frankieali commented 4 months ago

I'm planning to release v1.1.0 later this week. I just need to wrap up the docs. I'll also see what I can do to provide a gracefully fallback to this issue to avoid the breaking change.

Also, looks like npm no longer runs postinstall script prompts or terminal output. I'll have to update the docs for that as well.

frankieali commented 4 months ago

Closed with the release of v1.1