search

3d-dice / dice-box

3D Game Dice for any JavaScript App
https://fantasticdice.games/
MIT License
137 stars 30 forks source link

Suspend Simulation always returns NaN value #79

Closed watcherdm closed 1 year ago

watcherdm commented 1 year ago

Currently when the 3d simulated dice are disabled via configuration, the dice roller generates invalid NaN values as the call to Random.range is passed a string ("dNN") as the max argument.

frankieali commented 1 year ago

This change looks good and it fixes the issue. Just one minor syntax error that needs correcting and I can merge it in. Thanks for the fix!