search

3d0c / gmf

Go Media Framework
MIT License
885 stars 170 forks source link

fixed FFMPEG 5.1 issues #153

Closed harmreijnen closed 2 years ago

harmreijnen commented 2 years ago

added a couple additions to the fork of dubrsl/gmf to make gmf compatible with FFmpeg 5.1 see issue 3d0c#152

3d0c commented 2 years ago

Hello. Thank You for contribution. Regarding the code, I guess it won't work with previous versions of FFMpeg.

harmreijnen commented 2 years ago

Hello. No that's correct it will conflict with previous versions. In ffmpeg 5.1 they changed the names of a couple of classes (don't ask me why) what leads to gmf referring to nonexistent classes when using ffmpeg 5.1.

I forsee merging the code with the master branch will create issues for other developers not using 5.1.

gokalper commented 2 years ago

go.mod is incorrect preventing downloads of the module:

go get github.com/3d0c/gmf
go: downloading github.com/3d0c/gmf v0.0.0-20220906003747-3c1e70196c59
go: github.com/3d0c/gmf@v0.0.0-20220906003747-3c1e70196c59: parsing go.mod:
        module declares its path as: github.com/reijnenhhfm/gmf
                but was required as: github.com/3d0c/gmf
harmreijnen commented 2 years ago

my apologies. fixed this on my own repo, but i see it's been merged already, so that is no use.

gokalper commented 2 years ago

No worries, i issued another PR to address it.