search

3dcitydb / citydb-tool

3D City Database 5.0 CLI to import/export city model data and to run database operations
Apache License 2.0
9 stars 2 forks source link

Fix/docker metadata #21

Closed BWibo closed 5 months ago

BWibo commented 7 months ago

Fixes #20

clausnagel commented 6 months ago

Thanks, looks good to me and can be merged.

Let me raise my question in #20 again. If someone uses the "Dockerfile" to create his or her own image, this image will not contain any labels. The labels are only added to the images created in the GitHub actions, correct? When moved to the "Dockerfile", the labels would be considered in both scenarios.

BWibo commented 6 months ago

Oh yes, sry, I forgot to reply to that. Yes, that's true. The reason why we set the labels in the actions is that some of them (versions and dates) are set dynamically.

Here is the full list of labels. We overwrite just some of them.

            "Labels": {
                "maintainer": "Bruno Willenborg",
                "maintainer.email": "b.willenborg(at)tum.de",
                "maintainer.organization": "Chair of Geoinformatics, Technical University of Munich (TUM)",
                "org.opencontainers.image.authors": "Bruno Willenborg",
                "org.opencontainers.image.created": "2024-01-29T21:54:58.373Z",
                "org.opencontainers.image.description": "3D City Database 5.0 CLI to import/export city model data and to run database operations",
                "org.opencontainers.image.documentation": "https://github.com/3dcitydb/citydb-tool",
                "org.opencontainers.image.licenses": "Apache-2.0",
                "org.opencontainers.image.ref.name": "ubuntu",
                "org.opencontainers.image.revision": "dc3b61e9c14c9dc65cbc80b52f43f4ddf87a8494",
                "org.opencontainers.image.source": "https://github.com/3dcitydb/citydb-tool",
                "org.opencontainers.image.title": "3D City Database 5.0 CLI tool Docker image",
                "org.opencontainers.image.url": "https://github.com/3dcitydb/",
                "org.opencontainers.image.vendor": "3DCityDB Steering Committee",
                "org.opencontainers.image.version": "edge"
            }

We could move the labels with static text inside the image. The question is however, should an image built by somebody else have the same set of labels in it?