3dct / open_iA

A tool for the visual analysis and processing of volumetric datasets, with a focus on industrial computed tomography.
GNU General Public License v3.0
41 stars 16 forks source link

iAChartWithFunctionsWidget refactoring #45

Closed codeling closed 3 years ago

codeling commented 5 years ago

iAChartWithFunctionsWidget (in core/charts) takes an MdiChild* parameter in its constructor; yet this is only used to retrieve the current path of the mdichild e.g. when storing the transfer function. It would be better to remove the parameter. Instead, one could for example introduce an abstract interface class for retrieving a path (which MdiChild could implement); then pass in only a pointer/reference to this interface to iAChartWithFunctionsWidget; then it is not as tightly coupled to the MdiChild class anymore.