search

3dct / open_iA

A tool for the visual analysis and processing of volumetric datasets, with a focus on industrial computed tomography.
GNU General Public License v3.0
40 stars 16 forks source link

SlicingPlane removal and Client commands #75

Closed mdalpiaz closed 5 months ago

mdalpiaz commented 5 months ago

We don't need an ID for the slicing plane. When creating snapshots, the position and rotation details need to be sent anyway. Was there a reason why the SlicingPlane got a fixed ID?

mdalpiaz commented 5 months ago

We needed some commands to advertise newly connected or disconnected clients to other clients. This should ensure, that the virtual cameras are initialized correctly.

codeling commented 5 months ago

We don't need an ID for the slicing plane. When creating snapshots, the position and rotation details need to be sent anyway. Was there a reason why the SlicingPlane got a fixed ID?

I believe the idea was to be able to modify the slice plane as well, potentially interactively. I could see that make sense in direction client-server where client is "exploring" and server user wants to follow what he is seeing immediately without having to take a snapshot first. but the modify object commands only would make sense for me now with the added normal/up subcommand.

but the functionality described above would also require additional messages for the server to request starting and ending interactive updates from the client.

codeling commented 5 months ago

We needed some commands to advertise newly connected or disconnected clients to other clients. This should ensure, that the virtual cameras are initialized correctly.

principally I agree, but I would assign lower importance since the immediate plans focus on one client and one server.