3dem / model-angelo

Automatic atomic model building program for cryo-EM maps
MIT License
116 stars 18 forks source link

What would be the recomended way to update model angelo #14

Closed pconesa closed 1 year ago

pconesa commented 1 year ago

I'm asking in case there is a "shorted method" than removing the installation and starting again

I guess models could be in a different folder?

model_angelo setup.py installed in editable mode + git pull?

jamaliki commented 1 year ago

Do you mean if the weights are updated? The only real thing that would be updated is the model_angelo code itself, which if you git pull again and run python setup.py install will update. Does that answer your question?

pconesa commented 1 year ago

I think so, most time part of the installation are:

creating the environment and "downloading/preparing" models (apart from downloading and extracting models, does anything else happen)?

jamaliki commented 1 year ago

No, nothing apart from downloading and extracting the models.

pconesa commented 1 year ago

Nice, this was useful. If you are willing to contribute to the scipion plugin and make it better with your expertise, you are more than welcome. Let me know.

jamaliki commented 1 year ago

Sure! If you could point me to where the development is taking place.

pconesa commented 1 year ago

I just uploaded a working version of the plugin.... here: https://github.com/scipion-em/scipion-em-modelangelo

Protocol looks like this:

image

The installation part is done here, you might be able to understand how we are doing it: https://github.com/scipion-em/scipion-em-modelangelo/blob/devel/modelangelo/__init__.py#L73

Execution part is here: https://github.com/scipion-em/scipion-em-modelangelo/blob/devel/modelangelo/protocols/protocol_model_angelo.py#L90

NOTE: Output is taking the wrong files. I'll fix this.

jamaliki commented 1 year ago

Looks great :+1: