search

3dem / model-angelo

Automatic atomic model building program for cryo-EM maps
MIT License
110 stars 18 forks source link

Return error exit code #16

Closed pconesa closed 1 year ago

pconesa commented 1 year ago

Hi, it's me again. When modelangelo fails it actually does nor return any exit code and therefore programs calling modelangelo fail to detect the error.

Would it be possible to implement this?

Thanks.

jamaliki commented 1 year ago

Hi,

Yes that is a good idea. It is added now here: 921fdb6458125be6d2df5c9f378a93e545528547

pconesa commented 1 year ago

Great! I'll test it and get back here.

pconesa commented 1 year ago

Working fine! Thanks!

pconesa commented 1 year ago

Have we lost the exit code in the latest code?

jamaliki commented 1 year ago

That shouldn't be the case. Could you give me more details?

pconesa commented 1 year ago

After a git pull (I'm using "main" branch) I'm bask to where I when posting this issue.

I remember vaguely you added a sys.exit() call somewhere here but is not there anymore.

https://github.com/3dem/model-angelo/blob/main/model_angelo/apps/build.py#L119

pconesa commented 1 year ago

Wait! maybe I'm wrong and my installation is pointing to a old version.. let me check

jamaliki commented 1 year ago

I didn't remove the sys exit, so it should still be the same

pconesa commented 1 year ago

Sorry, my installation had an old version without it. After updating it to current main code all works.