3dem / relion

Image-processing software for cryo-electron microscopy
https://relion.readthedocs.io/en/latest/
GNU General Public License v2.0
444 stars 198 forks source link

relion_prepare_subtomograms.py crash under special case #154

Closed bforsbe closed 3 years ago

bforsbe commented 7 years ago

Originally reported by: Lu Gan (Bitbucket: lu_gan, GitHub: Unknown)


The current version of this script will fail to create the particles_subtomo.star file if SkipCTFCorrection = True and Relion2 = True.

Under this condition, the script does not create the directory OutputDir/results. There's probably a more elegant solution, but I was able to fix this problem by inserting this one-liner between lines 388 and 389:

#!python
      os.system('mkdir %s' %(OutputDir + 'results'))

Lines 388 - 390 now read:

#!python
    if Relion2 == True:
      os.system('mkdir %s' %(OutputDir + 'results'))
      outputstarname_read =  OutputDir + 'results/micrographs_ctf.star'

biochem-fan commented 3 years ago

We will not fix this script. We will have a completely new CryoET pipeline in the next major update.