search

3dem / relion

Image-processing software for cryo-electron microscopy
https://relion.readthedocs.io/en/latest/
GNU General Public License v2.0
444 stars 197 forks source link

RELION does not accept CR+LF new lines #527

Closed biochem-fan closed 3 years ago

biochem-fan commented 4 years ago

See https://www.jiscmail.ac.uk/cgi-bin/webadmin?A2=ind1910&L=CCPEM&O=D&P=138854.

We never officially supported such STAR files. The reported error itself was caused by the table name from data_XXXX being XXXX\r. This is easy to fix, but there are many other places that need modification. It might have appeared working in RELION 3.0, but it is merely by luck; for example, if a line ends with a string literal, probably the result is invalid.

For the purpose of record, I put up this issue, but do not promise I will implement this feature.

biochem-fan commented 3 years ago

It is better NOT to support CR+LF in RELION; external scripts might still fail.

Instead, I propose to give a clear error (than cryptic "failed to convert from 3.0") when CR is detected.

biochem-fan commented 3 years ago

Banned CR+LF in 74c35c2 (in 3.2; not public yet).