search

3dfxdev / EDGE

EDGE Source Code
http://edge2.sf.net
74 stars 10 forks source link

FEATURE: MP3 Support #86

Closed Some1NamedNate closed 2 years ago

Some1NamedNate commented 3 years ago

Software patents for the MP3 format expired in 2017. After finding out that older versions of EDGE had MP3 support, I thought I'd raise the alarm by saying, "MP3 is free now!"

Bringing back MP3 support would be great, which would mean that I can play MP3 music from SIGIL_SHREDS.wad, a paid enhancement to The Ultimate Doom MegaWAD "Sigil."

Corbachu commented 2 years ago

https://github.com/3dfxdev/EDGE/commit/d43980166490ed2e810d12cfd98863f3c41bf588

This was added as of the above commit. I indeed have the SIGIL registered version with the MP3 pack, when I first worked SIGIL support.

I'll wind this into playlists.DDF and test tonight. Provided all goes well, we will have a nice development release with other nifty features from @dashodanger and @Lobo, as well as other issues I've fixed related to those changes and additions.

Hopefully this will lead very soon into our first full release of EDGE (which due to 2.1.0's extremely long dev cycle, we will be instead releasing it as 2.2.0).

Corbachu commented 2 years ago

Works with SIGIL_SHREDS - when added alongside SIGIL (and DOOM.wad if you are combining with DOOM2), for now the entries in PLAYLISTS must be changed to MP3 manually. I'm currently adding a scanner to quickly check for the other formats if they exist FIRST, regardless of what the LUMP type is defined in DDF. Releasing new build here shortly.

Corbachu commented 2 years ago

I have forgotten but it already works as such without needing to edit the playlist DDF for the SIGIL entries. I don't quite remember though if EDGE already had this behaviour or if this is a physFS enhancement. Seems to be working alright, just doing more testing before closing the issue (loop music, test volume sliders, etc).

Corbachu commented 2 years ago

@dashodanger I've verified it works 100% in all cases, without the user needing to modify the playlist entries. Closing the PR!

@Some1NamedNate Try it out with the latest 64-bit devbuild , uploaded today (11/14/21) or at least later than r214.