search

3dgeo-heidelberg / py4dgeo

py4dgeo - A Python library for change analysis in 4D point clouds
https://py4dgeo.readthedocs.io
MIT License
76 stars 12 forks source link

Remove KDTree precomputation #109

Closed dokempf closed 2 years ago

dokempf commented 2 years ago

In the light of the new optimized cylinder search implementation this precomputation does not have a lot of benefits. At the same time, it can easily waste large amounts of memory.

This fixes #78.

codecov[bot] commented 2 years ago

Codecov Report

Merging #109 (3c4d663) into main (d6a46a8) will decrease coverage by 0.61%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   92.30%   91.69%   -0.62%     
==========================================
  Files          12       12              
  Lines         377      337      -40     
==========================================
- Hits          348      309      -39     
+ Misses         29       28       -1
Flag Coverage Δ
cxx 95.07% <ø> (-0.79%) :arrow_down:
python 89.23% <ø> (-0.20%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
py4dgeo/src/py4dgeo/m3c2.py 90.32% <0.00%> (-0.35%) :arrow_down:
py4dgeo/lib/kdtree.cpp 100.00% <0.00%> (ø)
py4dgeo/lib/directions.cpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6a46a8...3c4d663. Read the comment docs.