3dgeo-heidelberg / py4dgeo

py4dgeo - A Python library for change analysis in 4D point clouds
https://py4dgeo.readthedocs.io
MIT License
65 stars 9 forks source link

Perform seed sorting after detection and store sorted seeds (instead of before object segmentation "on the fly") #192

Closed kathapand closed 1 year ago

kathapand commented 2 years ago

Problem: Currently, seed sorting is performed after seed detection, meaning detected seeds are stored unsorted in the SpatiotemporalAnalysis object. Every time object extraction is started (using existent seeds), the sorting is repeated. For real data, this can take several hours (depending on the number of seeds and scoring funtion).

For common applications / usage, we can assume the sorting is linked to the seed detection and needs no repetition for segmentation (only if the entire seed detection is repeated). I therefore suggest to perform the sorting before storing the seeds, i.e. updating the indices.

Solution: This step should be performed already here.

@dokempf do you see an issue or pitfall here? If not, I can implement the proposed adaptation and include in my testing.

kathapand commented 1 year ago

solved by above commit, to be tested within branch. closing this issues.

DCHulskemper commented 1 year ago

This was reverted by merging from main. The change probably has to be re-implemented.