search

3dgeo-heidelberg / py4dgeo

py4dgeo - A Python library for change analysis in 4D point clouds
https://py4dgeo.readthedocs.io
MIT License
65 stars 9 forks source link

Enable selection of core points to consider as seed locations for 4D-OBC extraction #193

Closed kathapand closed 1 year ago

kathapand commented 2 years ago

Currently seed detection for 4D-OBC extraction is performed on all corepoints. Generally, it will be interesting for applications to restrict the potential seed locations to specific core points (not necessarily regular subsampling provided by seed_subsampling). It will also facilitate testing and debugging.

I suggest to change the parameter seed_subsampling to search_points (or similar) and take as input a set of core point indices. The default will be range(len(corepoints)). Subsampling can be easily passed via range(0,len(corepoints),n) with n being every nth corepoint (replicating current behavior).

kathapand commented 1 year ago

This is enabled by this commit: ced604bf5d42660efcb9f29c104d64ab362ff1b9. To be tested.

kathapand commented 1 year ago

Solved with #224