3dgeo-heidelberg / py4dgeo

py4dgeo - A Python library for change analysis in 4D point clouds
https://py4dgeo.readthedocs.io
MIT License
73 stars 10 forks source link

4D-OBC change detection: Window_with parameter causes runtime error #266

Open vivienzahs opened 1 year ago

vivienzahs commented 1 year ago

For the 4D-OBC change point detection, the window_width parameter is not allowed to be larger than the number of epochs in the dataset. This causes a RunTimeError ("empty score") to be raised during the seed point selection in the region growing any time when having generated the SpatiotemporalAnalysis object based on more than 2 epochs (1 reference epoch + several further epochs).

Maybe the limitation of this parameter to not be larger than the number of epochs in the dataset could be removed and a meaningful error message might be provided to the user to better identify where the issues comes from.

Happy to provide more information if required.