3dgeo-heidelberg / py4dgeo

py4dgeo - A Python library for change analysis in 4D point clouds
https://py4dgeo.readthedocs.io
MIT License
73 stars 10 forks source link

Integration pbm3c2 m3c2ep #268

Closed dokempf closed 1 year ago

dokempf commented 1 year ago

This merges both PB-M3C2 and M3C2-EP into main and applies the required compatibility fixes.

codecov-commenter commented 1 year ago

Codecov Report

Merging #268 (6ec9755) into main (41a2ba6) will decrease coverage by 15.02%. The diff coverage is 52.45%.

:exclamation: Current head 6ec9755 differs from pull request most recent head 1f10694. Consider uploading reports for the commit 1f10694 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268/graphs/tree.svg?width=650&height=150&src=pr&token=TUVklp2e6N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg)](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) ```diff @@ Coverage Diff @@ ## main #268 +/- ## =========================================== - Coverage 89.07% 74.06% -15.02% =========================================== Files 20 23 +3 Lines 1776 3100 +1324 =========================================== + Hits 1582 2296 +714 - Misses 194 804 +610 ``` | Flag | Coverage Δ | | |---|---|---| | cxx | `87.21% <ø> (+0.31%)` | :arrow_up: | | python | `69.32% <52.45%> (-21.58%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) | Coverage Δ | | |---|---|---| | [src/py4dgeo/UpdateableZipFile.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vVXBkYXRlYWJsZVppcEZpbGUucHk=) | `90.00% <ø> (ø)` | | | [src/py4dgeo/pbm3c2.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vcGJtM2MyLnB5) | `53.62% <ø> (ø)` | | | [src/py4dgeo/m3c2ep.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vbTNjMmVwLnB5) | `43.46% <43.46%> (ø)` | | | [src/py4dgeo/segmentation.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vc2VnbWVudGF0aW9uLnB5) | `89.92% <50.00%> (ø)` | | | [src/py4dgeo/epoch.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vZXBvY2gucHk=) | `90.00% <76.11%> (-2.25%)` | :arrow_down: | | [src/py4dgeo/\_\_init\_\_.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [src/py4dgeo/m3c2.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vbTNjMi5weQ==) | `93.13% <100.00%> (+1.99%)` | :arrow_up: | | [src/py4dgeo/util.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vdXRpbC5weQ==) | `87.50% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg). Last update [41a2ba6...1f10694](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/268?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg).