3dgeo-heidelberg / py4dgeo

py4dgeo - A Python library for change analysis in 4D point clouds
https://py4dgeo.readthedocs.io
MIT License
65 stars 8 forks source link

Fix reading normals from las #278

Closed DimasfromLavoisier closed 10 months ago

DimasfromLavoisier commented 10 months ago

Changed functions save, load and read_from_las in epoch.py file. Also, added some tests.

codecov-commenter commented 10 months ago

Codecov Report

Merging #278 (0eef599) into main (49283ed) will decrease coverage by 0.06%. The diff coverage is 95.23%.

:exclamation: Current head 0eef599 differs from pull request most recent head e0fad0b. Consider uploading reports for the commit e0fad0b to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/278/graphs/tree.svg?width=650&height=150&src=pr&token=TUVklp2e6N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg)](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) ```diff @@ Coverage Diff @@ ## main #278 +/- ## ========================================== - Coverage 74.79% 74.74% -0.06% ========================================== Files 26 26 Lines 3214 3231 +17 ========================================== + Hits 2404 2415 +11 - Misses 810 816 +6 ``` | [Flag](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/278/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) | Coverage Δ | | |---|---|---| | [cxx](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/278/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) | `87.21% <ø> (-0.72%)` | :arrow_down: | | [python](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/278/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) | `70.32% <95.23%> (+0.21%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) | Coverage Δ | | |---|---|---| | [src/py4dgeo/epoch.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vZXBvY2gucHk=) | `90.60% <94.73%> (+0.64%)` | :arrow_up: | | [src/py4dgeo/util.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vdXRpbC5weQ==) | `83.14% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/278/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/278?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/278?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg). Last update [49283ed...e0fad0b](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/278?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg).

:loudspeaker: Have feedback on the report? Share it here.