3dgeo-heidelberg / py4dgeo

py4dgeo - A Python library for change analysis in 4D point clouds
https://py4dgeo.readthedocs.io
MIT License
73 stars 10 forks source link

Cpp region growing #288

Closed DimasfromLavoisier closed 5 months ago

DimasfromLavoisier commented 11 months ago

Added function for supervoxel segmentation with minor changes for several other functions. There still issue with python part that I'll fix.

codecov-commenter commented 11 months ago

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (fbef6fd) 74.84% compared to head (7daa7a1) 75.83%.

:exclamation: Current head 7daa7a1 differs from pull request most recent head 6cfadf6. Consider uploading reports for the commit 6cfadf6 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288/graphs/tree.svg?width=650&height=150&src=pr&token=TUVklp2e6N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg)](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) ```diff @@ Coverage Diff @@ ## main #288 +/- ## ========================================== + Coverage 74.84% 75.83% +0.98% ========================================== Files 26 26 Lines 3252 3459 +207 ========================================== + Hits 2434 2623 +189 - Misses 818 836 +18 ``` | [Flag](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) | Coverage Δ | | |---|---|---| | [cxx](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) | `88.22% <90.95%> (+0.70%)` | :arrow_up: | | [python](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) | `70.40% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) | Coverage Δ | | |---|---|---| | [include/py4dgeo/kdtree.hpp](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-aW5jbHVkZS9weTRkZ2VvL2tkdHJlZS5ocHA=) | `100.00% <ø> (ø)` | | | [lib/kdtree.cpp](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-bGliL2tkdHJlZS5jcHA=) | `57.14% <100.00%> (-1.00%)` | :arrow_down: | | [src/py4dgeo/registration.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vcmVnaXN0cmF0aW9uLnB5) | `97.87% <100.00%> (+0.14%)` | :arrow_up: | | [src/py4dgeo/util.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vdXRpbC5weQ==) | `83.14% <100.00%> (ø)` | | | [tests/c++/kdtree\_t.cpp](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-dGVzdHMvYysrL2tkdHJlZV90LmNwcA==) | `100.00% <100.00%> (ø)` | | | [tests/c++/registration\_t.cpp](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-dGVzdHMvYysrL3JlZ2lzdHJhdGlvbl90LmNwcA==) | `95.74% <95.34%> (+8.24%)` | :arrow_up: | | [lib/registration.cpp](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-bGliL3JlZ2lzdHJhdGlvbi5jcHA=) | `89.77% <89.41%> (-10.23%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg). Last update [fbef6fd...6cfadf6](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/288?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg).