3dgeo-heidelberg / py4dgeo

py4dgeo - A Python library for change analysis in 4D point clouds
https://py4dgeo.readthedocs.io
MIT License
65 stars 8 forks source link

Point to plane icp #313

Closed DimasfromLavoisier closed 2 months ago

DimasfromLavoisier commented 6 months ago

Updated ICP methods according to the changes in cpp-region-growing

codecov-commenter commented 6 months ago

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (87fb289) 74.74% compared to head (c03483c) 76.68%. Report is 91 commits behind head on main.

:exclamation: Current head c03483c differs from pull request most recent head 85e846c. Consider uploading reports for the commit 85e846c to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313/graphs/tree.svg?width=650&height=150&src=pr&token=TUVklp2e6N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg)](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) ```diff @@ Coverage Diff @@ ## main #313 +/- ## ========================================== + Coverage 74.74% 76.68% +1.94% ========================================== Files 26 26 Lines 3231 3625 +394 ========================================== + Hits 2415 2780 +365 - Misses 816 845 +29 ``` | [Flag](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) | Coverage Δ | | |---|---|---| | [cxx](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) | `88.22% <89.33%> (+1.00%)` | :arrow_up: | | [python](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) | `71.96% <94.02%> (+1.64%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) | Coverage Δ | | |---|---|---| | [include/py4dgeo/kdtree.hpp](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-aW5jbHVkZS9weTRkZ2VvL2tkdHJlZS5ocHA=) | `100.00% <ø> (ø)` | | | [src/py4dgeo/\_\_init\_\_.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [src/py4dgeo/util.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vdXRpbC5weQ==) | `83.14% <100.00%> (ø)` | | | [tests/c++/kdtree\_t.cpp](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-dGVzdHMvYysrL2tkdHJlZV90LmNwcA==) | `100.00% <100.00%> (ø)` | | | [tests/c++/registration\_t.cpp](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-dGVzdHMvYysrL3JlZ2lzdHJhdGlvbl90LmNwcA==) | `95.74% <95.34%> (+8.24%)` | :arrow_up: | | [src/py4dgeo/epoch.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vZXBvY2gucHk=) | `89.81% <81.25%> (-0.79%)` | :arrow_down: | | [lib/kdtree.cpp](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-bGliL2tkdHJlZS5jcHA=) | `57.14% <33.33%> (-6.96%)` | :arrow_down: | | [src/py4dgeo/registration.py](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-c3JjL3B5NGRnZW8vcmVnaXN0cmF0aW9uLnB5) | `95.30% <95.05%> (-4.70%)` | :arrow_down: | | [lib/registration.cpp](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg#diff-bGliL3JlZ2lzdHJhdGlvbi5jcHA=) | `89.77% <89.41%> (-10.23%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg). Last update [87fb289...85e846c](https://app.codecov.io/gh/3dgeo-heidelberg/py4dgeo/pull/313?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3dgeo-heidelberg).