Remove pybind11 submodule

3dgeo-heidelberg / py4dgeo

py4dgeo - A Python library for change analysis in 4D point clouds

https://py4dgeo.readthedocs.io

MIT License

78 stars 12 forks source link

Remove pybind11 submodule #334

Closed dokempf closed 5 months ago

dokempf commented 5 months ago

Instead of using pybind11 as a submodule, we could just depend on it as a Python package. I am bringing this up, because I just spent too much time finding a bug with newer versions of Python that were already fixed in pybind11. Also, pybind11 is mature enough to not expect regular breakage (also, it follows semantic versioning).

dokempf commented 5 months ago

As a downside, manual CMake builds (outside pip) would get more complicated to do.

dokempf commented 5 months ago

I also investigated whether we could bump the submodule more of often with dependabot, but they do not support the required bumping to tagged release commits: https://github.com/dependabot/dependabot-core/issues/1639