3dlg-hcvc / DuoduoCLIP

34 stars 0 forks source link

Question about is_multi_view configuration in training #3

Closed sumuru789 closed 1 week ago

sumuru789 commented 1 month ago

Hello,

First of all, I want to say that I am very interested in your work. I have been exploring your code and I noticed that in the configuration, the is_multi_view parameter is set to False by default: is_multi_view: Optional[bool] = False Could you please clarify whether this parameter was set to False or True during your training process?

Thank you for your help!

hanhung commented 1 month ago

Hi,

I think you are referring to line 56 in src/custom_clip/model.py. Here the default is indeed False. However, in the get_model function in src/model/duoduoclip.py we create the multi-view CLIP model with configs in src/custom_clip/model_configs/ViT-B-32-MV.json where the parameter is set to True "is_multi_view": true.

Hope that helps!

sumuru789 commented 1 month ago

Thank you for your prompt response and clarification. I appreciate your help!