3dmol / 3Dmol.js

WebGL accelerated JavaScript molecular graphics library
https://3dmol.org/
Other
813 stars 195 forks source link

Add more folders to .npmignore #665

Closed NicolasCARPi closed 1 year ago

NicolasCARPi commented 1 year ago

Hello,

Installing 3Dmol.js with npm results in a 40 Mb folder. Looking into the size distribution, we can see that a lot of space is used by the python stuff:

2023-03-26-140757_1074x654_scrot

And we definitely don't need all these examples and non-production code when installing the package. Especially the notebooks chekpoints!

So here is a PR that will make the npm install lighter.

Here is how it looks before:

pack-master

And after:

pack-npmignore

As a side note, I would suggest splitting the python code into another repository, as I believe it makes more sense to separate JS and Python projects, which have different tooling and environments.

codecov[bot] commented 1 year ago

Codecov Report

Merging #665 (d192d46) into master (93a2944) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #665   +/-   ##
=======================================
  Coverage   83.04%   83.04%           
=======================================
  Files         141      141           
  Lines       11445    11445           
  Branches     2106     2106           
=======================================
  Hits         9504     9504           
  Misses       1609     1609           
  Partials      332      332           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

NicolasCARPi commented 1 year ago

Thanks for the rapid merge @dkoes. Now we can test the new github action to publish a new package? :)