3dmol / 3Dmol.js

WebGL accelerated JavaScript molecular graphics library
https://3dmol.org/
Other
794 stars 194 forks source link

[Feat] - Added Jest Reporter Capability #669

Closed adithyaakrishna closed 1 year ago

adithyaakrishna commented 1 year ago

Description:

This creates a new file known as test-report.html which has all the jest coverage results. This PR also includes a CI to commit the generated test-report file to a new branch jest-test-report from which the test report generated can be accessed.

Also, I have updated the scripts to accommodate the new test changes

adithyaakrishna commented 1 year ago

@dkoes Have disabled the Workflow for committing test-report as we do not have a branch under the name jest-test-report hence the CI is failing here. Could you please create a new branch under the name of jest-test-report or if any other name, please do let me know so that I can update the workflow file as well :)

dkoes commented 1 year ago

What is trying to be accomplished here? Why is a separate branch needed? I do not want to change the behavior of npm test

adithyaakrishna commented 1 year ago

Hi @dkoes The main intention behind this PR was to add a way to measure performance changes through tests. The reporter creates a new .HTML file with the test report measuring how long it took for that to run.

Okay sure, I will update the script fornpm test to how it was before and add a new script for the coverage one.