search

3dmol / 3Dmol.js

WebGL accelerated JavaScript molecular graphics library
https://3dmol.org/
Other
813 stars 195 forks source link

[Feat] - Updated http links to https #680

Closed adithyaakrishna closed 1 year ago

adithyaakrishna commented 1 year ago

Description:

adithyaakrishna commented 1 year ago

This is strange, I havent touched any js files but the CI is failing :/

dkoes commented 1 year ago

The caching stuff was recently merged. Looking through the CI log, I do not see where the package is actually being built? And the error is build/3Dmol.js doesn't exist. Can you review your caching code to make sure it always rebuilds 3Dmol?

codecov[bot] commented 1 year ago

Codecov Report

Merging #680 (43bf4c0) into master (80fc603) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #680   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files         141      141           
  Lines       11450    11450           
  Branches     2112     2112           
=======================================
  Hits         9505     9505           
  Misses       1613     1613           
  Partials      332      332
adithyaakrishna commented 1 year ago

@dkoes Tests are passing and CI is Successful :)