Include ranges in typing for resi `AtomSelectionSpec`

3dmol / 3Dmol.js

WebGL accelerated JavaScript molecular graphics library

https://3dmol.org/

Other

794 stars 194 forks source link

Include ranges in typing for resi `AtomSelectionSpec` #728

Closed randyn closed 11 months ago

randyn commented 11 months ago

Adds a literal type for a SelectionRange and adds it into the union type for resi
Adds arrays as a valid type for resi as well

There are a couple other fields on AtomSpec that are also typed as number, but I'm not sure which ones we intentionally want to allow ranges for. I'm happy to update those too, this just happened to be the only one I'm looking at right onw

dkoes commented 11 months ago

Better typing is always appreciated! Although maintaining the whitespace style makes for a cleaner diff.