search

3dmol / 3Dmol.js

WebGL accelerated JavaScript molecular graphics library
Other
770 stars 191 forks source link

Refactor remaining files in parser/utils #761

Closed prajwalkulkarni closed 5 months ago

prajwalkulkarni commented 5 months ago

:dizzy: Changelog

:star: Improved typesafety in the remaining TS files located in parser/utils. :star: Changed var to let and const as applicable. :star: Added strict equality check :star: If the name of identifiers of key and value are the same, do not pass the value identifier explicitly. E.g: Instead of using atoms.push({x:x,y:y}) simply use atoms.push({x,y})

codecov[bot] commented 5 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8c3e9d4) 82.62% compared to head (ca7ecbd) 82.59%.

Files Patch % Lines
src/parsers/utils/getSinglePDB.ts 95.34% 1 Missing and 1 partial :warning:
src/parsers/utils/assignPDBBonds.ts 92.30% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #761 +/- ## ========================================== - Coverage 82.62% 82.59% -0.03% ========================================== Files 141 141 Lines 11496 11495 -1 Branches 2126 2126 ========================================== - Hits 9498 9494 -4 - Misses 1667 1670 +3 Partials 331 331 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.