search

3dots / EROptimizer

Elden Ring armor optimizer
6 stars 0 forks source link

The "Armor Filters" page loads very slowly #7

Closed cridus closed 1 year ago

cridus commented 1 year ago

Can you please make the loading asynchronous, so that the site doesn't freeze? It takes several seconds to load >.< Thanks

3dots commented 1 year ago

So it's not actually the app that's freezing. It's the browser struggling to render all the sets with all the buttons. Short of only rendering a limited number of sets, I don't know what else can be done. If I do that though, I'd also need to add a "search" field, otherwise how do you find a particular piece to disable? I'd also need to somehow create Prev/Next buttons, or make scroll dynamically add more records and hide previous ones... it's a lot of work.

cridus commented 1 year ago

I remember that it was much faster in the past though... welp.

3dots commented 1 year ago

One eternity later...

I made the autocompletes default state use the same list instead of creating 4 lists of the same data.

image

Maybe that will help?

I couldn't really spot a difference myself back in November, that's why I am committing this only now.

If you're still using the tool, let me know if it helps.

cridus commented 1 year ago

Yeah, it's faster now 🎉 But why is that tab slow every time an not only the first time?

3dots commented 1 year ago

Because I think when you switch views, angular garbage collects the view, which includes the autocompletes that have the lists.

I think I am going to close this for now. Who knows, if DLC adds 100 more armor sets, then I'll have to do overhaul the rendering not to put all the records, but don't think I have the resolve to do it now.