Closed sergibot closed 5 years ago
sergibot
commented
6 years ago sign up page cuts off (and no scroll bar) (both ffox and chrome)
Sign up page has no scroll bar and extends below the default bottom of browser screen. This cuts off the Pricing and Login buttons! Only way to see all currently is by zooming out (eg viewing at 90% as I do in pic below)
in ffox -
in chrome (fixed by zooming out) -
sergibot
commented
6 years ago file format error not displayed in model upload box
When uploading an unsupported file format as a model, user isn't told the file format isn't supported until the model upload box has closed. ALSO "Uploading" remains displayed next to model name and doesn't change OR let user access model options until page refreshed. (When the page has been refreshed, the model shows a blank where the upload status/date would be, which is correct.) On the other hand, if user tries to upload that file as a model revision then the "not supported" text appears in the upload box - before attempting upload. This is better?
and to highlight the "uploading" status remaining until page refresh:
sergibot
commented
6 years ago should DIFF un-isolate/un-hide things in Base?
Currently, the DIFF tool takes whatever is visible in the model as its Base model and compares that to the Target model. This may be unexpected and may confuse users who are using DIFF right after eg viewing an issue which has objects isolated in its captured state - these users may think these objects are missing from the Base model full stop (rather than missing only because isolated within the issue view whose isolation continues after the issues card is closed). Does the DIFF tool want to refresh the state of the current model before comparing it? i.e. remove all objects from isolated/hidden states?
sergibot
commented
6 years ago long usernames push Permissions options out of alignment
Usernames longer than about 15 letters push the options in Permissions away from the corresponding column titles above
sergibot
commented
6 years ago add model box gives NEITHER too-long rev name error prompt NOR same-name error prompt
In upload model box, user is not told that the cause of their "Invalid revision name" error may be exceeding possible revision name length. On the other hand, in upload model revision box the "invalid rev name" error message is informative (see pictures below). ... Also, in create model box user is not informed of any other models with the same name as the name they have input until they click the save button - then they get a separate pop-up, and have to go fill out the create model info from scratch. There is an error message in-box when the same thing is tried with a federation (see pictures below).
...
sergibot
commented
6 years ago revision change button bug
If user clicks revision change button more than once before it loads up (for the first time within a model), the revisions box loads up however many times they clicked it (which could be a few in frustration if their web connection is slow).
sergibot
commented
6 years ago tree bug
The tree bugs out and adds a lot of vertical white space before all tree options (which you can scroll down into - once you click a plus sign and then scroll right back up to the top, the tree returns to normal), if you multi-select three things then multi-select the root of the tree too.
(Note that where I specify below to select three objects, this is to make the effect clearer. The bug occurs when one object is selected before multi-selecting the root.) (Also note - the screenshots and gifs below are taken in prod not dev, but the error still occurs in dev - but when you include the root in multi-selection it deselects everything!)
funnily enough, in this other house model the ground is not the tree's root but all of the (literal physical) trees are
sergibot
commented
6 years ago switching to turntable navigation levels viewpoint (jarring UI)
When a user switches from helicopter navigation mode to turntable nav mode, the viewpoint levels out to look at the horizon. This more often than not points the user away from the part of the model they were looking at. This occurs even when an object is selected - the viewpoint is directed away (is levelled so that it is horizontal).
sergibot
commented
6 years ago deselecting groups colour override deselects any overlap with other overrides
Colour override doesn't treat overlap as part of both groups.
sergibot
commented
6 years ago Clip buttons held highlighted when user changes tabs and back
The circular button of the selected item in the Clip Card - one of the X/Y/Z buttons, or even the slider! - is highlighted (as if its selection animation freezes at max opacity frame) when the user changes browser tab and returns to (dev.)3DRepo.io browser tab. This effect lasts until the user clicks on any button (on any card or sidebar) - but clicking on model won't disable the effect. (Occurs in Firefox and Chrome)
normal clip card appearance
if user clicks a button on the clip card then changes tab and back, that button is highlighted
sergibot
commented
6 years ago Enhancement: should Clip be available along custom planes?
Just raising this thought - users may want to adjust the Clip angle? Not in terms of the Z plane, but simply turning the Clip wall? Would be an advanced feature but could have e.g. a circle with a dot slider around its circumference, and a line along the diameter from that dot to the other side of the circle - drag the dot to change the angle of the wall (Starting at y plane |-> and heading eg past -v- , <-| , and -^- back to |-> , the arrow pointing in the direction of model visibility. Currently all four of these options are available, but easy access to angles between them could improve Clip's usability...) It is true that Selection Box (shift-clickdrag) has a similar effect to this, but Selection Box doesn't cross-section objects and can't be easily adjusted by a slider or by changing a number. Clip is a good tool but is limited to 3 planes/angles...?
sergibot
commented
6 years ago Enhancement: add option to retake issue screenshot
If user takes bad screenshot (or doesn't realise/remember screenshot is being saved with issue), they are currently stuck with that screenshot and have no way of retaking it. Add "edit screenshot" button? Also note that since issues cannot be deleted, but only closed, the issue screenshot cannot be deleted and retaken with a fresh issue - and if users do this, they will clog up the Issues list when anyone clicks "Show Closed Issues".
sergibot
commented
6 years ago group/issue creation/editor shrinks card so pointless scrollbar present
The group/issues card shrinks when a user tries to add a group/issue - shrinking just enough that a few things (pointless in both cases) are chopped off and have to be scrolled to. Just expand the group/issue creator card?
sergibot
commented
6 years ago isolate and hide unhighlight selection (don't deselect, but look like they do)
The isolate tool appears to deselect the things it isolates - so the object selection looks like it is clear - but it doesn't! This could confuse users since things which were selected (and highlighted, so visibly selected) are now invisibly selected. Obviously this doesn't matter once the user clicks anything else (unless they are holding CTRL at the time), as doing so will deselect them anyway - still, either the isolate tool should either deselect any selected objects (if it de-highlights them), or keep them selected and highlighted. The same is the case with the Hide tool.
sergibot
commented
6 years ago can't upload BCF to older revisions
For any revision older than the latest, the option to import BCF looks like it's there - if a user clicks the import BCF button, the usual file choice box pops up as if it will let the user import the file they choose, but choosing any file does nothing. Grey out this option from the menu when an older revision is open? Or remove it altogether?
(selecting a bcf file to upload does nothing, no error message even)
sergibot
commented
6 years ago add project no samename error
If you try to create a project with the same name as one which has already been created in that namespace, no error appears telling you that name has already been taken - in fact, nothing happens.
sergibot
commented
6 years ago clicking issues/issue descriptions flashes selected objects EDIT: notabug, talked w charence
Clicking on issues in the issues list makes the objects that are selected within the issue flash to their normal colours (instead of being highlighted) Clicking on an issue's description (once the issue has been created) makes the objects flash. Flashing also occurs when description clicked during description edit. Doesn't flash when description clicked during issue creation.
issues list clicking flashes
issue description clicking flashes
(another eg, to show it's not to do with "no description")
flash also occurs when editing description
but no problem during issue creation
Quick summary GIF showing clicks which flash the issue-selected objects:
sergibot
commented
6 years ago error msg appears on every refresh
Not sure if this is every user's experience, but I always receive this error message when I refresh the page...
sergibot
commented
6 years ago occasional update msg?
Solved - been explained to me, cheers! This is probably intentional but just noting that there's an occasional pop-up about refreshing to get the most updated version of 3D Repo. 3D Repo may have gone from 2.13.2 to 2.13.3 between this screenshot and the last visit I made to dev in this browser. (Once I reloaded the page, the text at the bottom of the login screen was still 2.13.3)
sergibot
commented
6 years ago Clip eye icon bugs
FOR CLARITY: EYE OPEN = CLIP ACTIVE ; EYE CROSSED OUT = CLIP INACTIVE However... When the Clip Card is opened, the eye icon is crossed-out (indicating that Clip is inactive). When the eye icon clicked, it remains crossed-out (which is now correct, because Clip becomes inactive). (From this point on, it is correct.) AND After a user has clicked the eye icon to deactivate Clip (making the eye icon appear crossed-out), if they click the invert Clip button then this re-activates Clip but doesn't affect the eye icon - this stays crossed-out.
This happens if, while Clip is inactive, a user clicks the Invert Clip Direction button, or if they change the units (e.g. from cm to dm). The eye icon remains crossed through even though Clip becomes active.
sergibot
commented
6 years ago tables on Cookies and Privacy webpages are too slim (nice-to-have)
The tables on the Cookies and Privacy webpages ( https://www.3drepo.io/cookies ) are very thin, and so very tall. Add some formatting so it looks better?
Cookies:
Privacy:
sergibot
commented
6 years ago Careers webpage header photo cuts off heads (3drepo.org)
The photo on the Careers webpage isn't very well-aligned, and so (in usual computer-screen browsing mode at least) cuts off everyone's head except Carmen's. It's more a gallery of arms and legs than welcoming faces at the moment (is Jozef double-jointed? Check out the second-leftmost elbow!). (However, this may have been the intention in that nobody really wanted faces to be seen - perfectly fine if so, no adjustment necessary then.)
sergibot
commented
6 years ago Careers job listing info too copy-pasted? (3drepo.org)
The job descriptions for Software Developer and Unity Developer begin with the same three paragraphs that appear under the JS Developer job listing. This would be fine as a copy-paste job except for the italicized phrase JavaScript Full Stack Developer that appears in each. Change this phrase, keep the rest?
JS listing:
Software Dev listing:
Unity Dev listing:
sergibot
commented
6 years ago Privacy webpage could use tidying...
The text on the Privacy webpage has a few errors - it looks like some closing tags are missing, etc.
sergibot
commented
6 years ago clip icon shows not clipping, when view activates clipping
The clip icon, if set to "clip not active", remains showing "clip not active" when a saved view is clicked for which clipping is active. Very minor tweak but the clip eye icon should turn to "active" (i.e. not crossed out) when a view in which clipping is active is clicked. Otherwise the clip icon shows clipping to be inactive while it is actually active.
sergibot
commented
6 years ago map tiles cover over pins and sometimes the clipping frame
All map tiles cover over pins and some map tiles cover over the clipping frame. By "cover over", I mean "make invisible, as if opaque and placed on top of". The GIFs will make this clear...
sergibot
commented
6 years ago no word limit in Group Descriptions
There is currently no character limit for Group Descriptions - I was able to put 1.5million words in a group description.
sergibot
commented
6 years ago Assign Permissions page lets users attempt to grant permissions to projects they are not admins for
Users can reach an "unauthorized" error by changing the selected teamspace and project to ones they are not admins of. Surely the unauthorized options should not be in the lists? So in the case below, I should not even have Charence's options in my Permissions menus, since I am not Admin in them and so could not grant any permissions within them?
and this is how it affects the other permissions tabs:
sergibot
commented
6 years ago viewers get option to delete all groups
Users with only Viewer permissions on a model are shown the "Delete all (groups)" option, and even the "are you sure?" pop-up, when they cannot do this (clicking yes does nothing - the groups remain, the buttons are ineffective).
sergibot
commented
6 years ago delete group option visible to viewers, clicking -> error popup
Users with only viewer permissions on a model appear to have the option to delete a group - the button to do so is visible to them. When clicked, this button brings up an error popup. Can we make this bin button invisible to users with only Viewer (...or also Commenter?) permissions?
sergibot
commented
6 years ago group colour override tick vanishes
If a user turns override on, then enters and exits the group editor, the override appears to be off even though no colour overrides could have been changed whilst the user was in the group editor.
sergibot
commented
6 years ago Viewers shown option to delete views
As above, but with views. Is there a way to put, say, a cross through the bin icon to indicate it is not clickable? Other possible solutions:
sergibot
commented
6 years ago glass tiles cover leaves and pins
As above (where map tiles always appear as if above any pins), but with glass tiles always appearing as if above any leaves in the trees in the Farnsworth house model. Glass also appears as if above pins.
sergibot
commented
6 years ago at great heights, maps keep refreshing (and sometimes only partially loading in if at all)
EDIT - the open street maps seem to be working fine now on prod! (6 hours later) EDIT EDIT - whether it works or not seems to vary depending on where the GIS reference is locating the model in the world: eg it works from Dubai (hence above edit), but not from UK or Lithuania. Will continue testing...
On current prod's open street map, ascending to great heights (using heli and say 40 nav speed) reaches a point at which the map tiles continually load in and then disappear. Sometimes only certain seemingly random tiles are doing this loading-in cycle while the rest don't load in at all. Seems to happen earlier (i.e. start to happen at a lower height) if looking out at horizon, but also happens looking straight down in birds-eye view at a greater height.
Also, while ascending and descending trying to take a good GIF, a big error box popped up:
sergibot
commented
6 years ago icarus - fly too high and the maps disappear
Once the viewpoint reaches a certain height, the maps no longer load in. Possibly connected to the above problem...
sergibot
commented
6 years ago permissions - should viewers&commenters be able to see GIS info?
Currently, users with viewer or commenter permissions on a model cannot access the model settings for that model, and so are unable to see the GIS information. Should they be able to see GIS information?
sergibot
commented
6 years ago permissions - should viewers&commenters be able to download the model they're viewing/commenting?
Currently, users with viewer or commenter permissions on a model are not able to download that model - should they be?
sergibot
commented
6 years ago federation collaborators see "permissions" option in fed option list
Users with Collaborator permissions on a federation seem to have the option of editing the permissions for that federation. If this option is clicked, an error message pops up. This is only for federations - there is no Permissions option in the menu for any models.
and nothing appears in the permissions editor
no equivalent option in menu for models:
sergibot
commented
6 years ago first-time users get invalid security certificate for https://3drepo.io
Remember this happening when I first tried to find 3drepo.io and trying to access the site on a fresh laptop it's occurred again. Notified someone in person the first time but just logging this here so there's a record of it - seems to occur the first time a computer tries to access 3drepo.io but never after that... On my usual computer typing 3drepo.io into the address bar takes me to https://www.3drepo.io ; on a new computer trying that led to https://3drepo.io and the error message about insecure connection. (Once the computer has visited www.3drepo.io it seems to remember that, and heads to it from then on.)
sergibot
commented
6 years ago navigation sometimes jarring
Just a note that because the panning (middle-click turntable) navigation slows down drastically if an object is in front of it (?) and speeds up instantly when nothing is in front (?), navigation on MEP models and similar (where there are random stretches of empty space between objects) can get very jarring (because the viewer skips instantly across the space parts and slows to a snails pace across any objects). This is limited to such models, and there are other modes of navigation available, but some users may specialise in MEP etc and may not like the heli nav mode, preferring to middle-mouse-wheel around. Could a solution be to accelerate and decelerate between viewing objects and viewing space? The second GIF demonstrates that the problem is also quite severe on house interiors...
sergibot
commented
6 years ago compare allows clicking base/compare/target at any time, compares to nothing
The Compare tool lets users click on the base/compare/target buttons even when a comparison is not active (when the "Enable/Disable 3D Diff/Clash" button in the bottom-right of the compare card is not red). Clicking these uses whichever comparison tool was last enabled to compare the current model (in base) to nothing (in target), leading to a bright green model or a greyscale model if the user clicks the "compare" button, and to an absence of model if they click the "target" button.
sergibot
commented
6 years ago due date not formatted right in issues print
Clicking the issues card's options, then the option to Print, brings up a PDF in a new tab. On this PDF the different changes that have been made to an issue are listed. The due date is not formatted right in two ways:
sergibot
commented
6 years ago Issue history list is badly formatted
The text in the action history for Issues is badly formatted in two ways:
EDIT - the Notification text colliding with event text may have been anomalous (here is a picture of it working fine), I will update if the text collision occurs again...
sergibot
commented
6 years ago clickdrag (turntable) still places pin
Clicking and dragging the viewer around a pivot centre point is a primary method of getting around the model using the turntable navigation method. When placing a pin, the user may well want to zoom in to check if they have placed the pin in the correct location. With the pin tool active, the "clickdrag" way of getting around replaces a pin on whatever object was clicked at the start of the clickdrag. If the clickdrag's first click was on nothing, on no object, then the pin is not replaced and remains where it is. Otherwise, the pin is immediately replaced to the location of the clickdrag's click. This is too sensitive: in contrast, multi-select (holding CTRL and clicking objects) does not select an object if clickdrag begins by clicking it.
(what's happening here is that whenever I click-drag to pivot the model, that click-drag's click places the pin elsewhere...)
sergibot
commented
6 years ago references to "Meta" tool (not "BIM") in Sample House comments
In the first issue's comments on the Lego Architecture model, there are multiple references to the "Meta" tool. This should now refer to the "BIM" tool.
sergibot
commented
6 years ago here maps satellite toggles buggy @Charence :)
The toggles for "Aerial Imagery" and for "Traffic Flow" seem not to load their respective things in if you tick both then untick one and try to tick it again.
sergibot
commented
6 years ago unnecessary textbox resize option
There is occasionally an option to resize textboxes, but sometimes this option can be redundant. The textbox resize option on the Views list, which appears when a user is editing a View's name, adds nothing positive to the UI and looks weird if used to either shrink or expand the textbox's space.
The resize button does not permit the user to expand the textbox vertically but only horizontally, which is counterproductive because the horizontal expansion extends beyond what is visible on the screen. The resize option could perhaps be redeemed if vertical expansion were allowed and horizontal expansion were removed.
The resize button is also unintuitive and feels hard to click - this is because the draggable button is on the inside of the box's corner, rather than being the corner itself which is far more commonly the case.
sergibot
commented
6 years ago GIS info edit has tiny arrow buttons
The up and down arrow buttons - used to change the GIS reference information in Model Settings - are so small that they are very hard to click without the user really concentrating on clicking the right button.
Also, interestingly, the up/down buttons are all always visible in Firefox but are only visible on click-focus in Chrome. (In Chrome the buttons are slightly bigger but are still small and indeed are too light a grey to be easily distinguished from the background.)
Firefox:
Chrome:
sergibot
commented
6 years ago no reason given when model settings unsaveable due to symbols in model code
When a user tries to put symbols or accented characters (eg. é) into the model code section within Model Settings, the settings refuse to save but don't give a reason. A pop-up here would help identify the cause of the problem.
sergibot
commented
6 years ago some highlighted/colour-overrided objects show through others
When objects are highlighted, some of them can show through or appear to be closer to the camera than others (which are highlighted and closer to the camera). This also happens with colour override (see pic and GIF of funky trees below). This seems similar and perhaps related to the tile bug and glass material bug, above.
Assign Permissions page lets users attempt to grant permissions to projects they are not admins forignore for now as we're revamping it