Migration: GIS - Githubissues

3drepo / 3drepo.io

3D Repo web server

http://www.3drepo.io

GNU Affero General Public License v3.0

95 stars 38 forks source link

Migration: GIS #1249

Closed simplypixi closed 5 years ago

simplypixi commented 6 years ago

Description

Migration of GIS panel.

Tasks

Create a new panel component
Create a new GIS component
Adapt the panel service and component to handling React components

Extras

design: https://xd.adobe.com/view/8a6b23f1-36b6-4419-5fe3-78a60d7ee17d-fc5a/
if maps are configured show map layers as it is now
if maps are not configured display model settings with save button in the toolbar at the bottom of the card as shown in prototype
add menu button in the header
menu has only one option "Settings" to open settings in card again in case user wants to change them

dleszcz commented 6 years ago

Hi @paloknapo !

You wrote: "if maps are not configured display model settings with save button in the toolbar at the bottom of the card as shown in prototype"

screenshot 2018-11-26 at 10 14 02

But, should it be a form, right? I ask because i can see only dislaying some data with no any inputs.

carmenfan commented 6 years ago

Hi @paloknapo !

You wrote: "if maps are not configured display model settings with save button in the toolbar at the bottom of the card as shown in prototype"

But, should it be a form, right? I ask because i can see only dislaying some data with no any inputs.

Yes it should be a form, it's basically the GIS part within model settings

also, we should probably remove elevation from this. As it is not used right now and we don't plan to add anything that requires it in the near future.

dleszcz commented 6 years ago

Thanks @carmenfan , Also:

If maps are not configured. Settings should be a default view with disabled menu button? or hidden? or with link to map layers?
If maps are configured and user go to settings. How to get back to the map layers view? By link in menu list? or some back arrow?

cc: @paloknapo

carmenfan commented 6 years ago

Thanks @carmenfan , Also:

If maps are not configured. Settings should be a default view with disabled menu button? or hidden? or with link to map layers?

If maps are configured and user go to settings. How to get back to the map layers view? By link in menu list? or some back arrow?

cc: @paloknapo

Settings should be a default view, with the back arrow disabled.
I think we should have a back arrow like the other tabs on the settings page.

In general once the user saved the settings with GIS values they should be directed to the map layers view.

paloknapo commented 6 years ago

If in settings back arrow appears in header, same as in Issues. If the map layer is on, user can save settings to see if maps fit and than goes back to layers view. See updated prototype:

https://xd.adobe.com/view/8a6b23f1-36b6-4419-5fe3-78a60d7ee17d-fc5a/

dleszcz commented 6 years ago

Thanks @carmenfan @paloknapo, everything is clear now 👍