1.13 bugs v2

[carmenfan]

Actual Bugs:

• [x] Billings page hangs forever unless you load the license page first
• [x] Being a Teamspace admin no longer automatically make you a project admin
• [x] Only teamspace owner is being automatically assigned as model admins
• [x] Paypal button is missing on the billings page
• [x] Permissions still need cleaning up
• [x] As a project admin I'm not getting permission on the side menu for models
• [x] Pin should take precedence over measuring tool
• [x] Bugs around multi-select
• [x] Bugs when you load an earlier revision
• [x] Page doesn't hook up to the chat server upon refresh
• [x] Forgot password page still doesn't work
• [x] Occasionally components + viewer doesn't load
• [x] Invalid Revision name when it looks valid
• [x] Import failure message is stopping user from viewing the previous revision of the model
• [x] Can't delete model. Error: Internal Error
• [x] Can't deselect multi-selected objects or select other objects when created new issue
• [x] 3D Viewer jerks when one card is opened and opening or closing the second card
• [x] Users deleted with GUI appear in Teamspace Permissions
• [X] Upload dialog doesn't go away when I hit UPLOAD button
• [x] Missing reset password page
• [x] Selected objects not saved with issue
• [x] Issues filter reset doesn't show all issues
• [x] Jobs list multiplied in issues menu in federation
• [X] Revisions fail to load in the viewer
• [x] Partial failures are being shown as Failed to import once refreshed
• [x] Show resolved issues doesn't work
• [x] Unassigned Models message is not true
• [x] Print issues not working
• [x] Can't select some objects
• [x] Issues: Pins of closed issues don't disappear
• [x] Pins of submodel issues are being shown when the issue themselves are not shown
• [x] URL not changing upon verifying new account
• [x] Freshly created project doesn't show up on "Add Model"

Logic weirdness:

• [x] multiple API calls before upload

UI Oddities:

• [x] Error message doesn't disappear when error is rectified on fed create tab
• [x] Default units are not consistent between models and federations
• [x] Please Check Input???
• [x] 2 letter model names are invalid but it's not obvious
• [x] Allow taking screenshot in an issue before typing comment
• [x] User Teamspace expanded by default
• [x] Deactivate measuring tool when leaving model
• [x] Make "New Comment" in issue clickable
• [x] Loading wheel never goes away from the Licences page
• [x] Select Models/Federation pop up too short
• [x] Make Admin radio buttons in models/federations permissions gray
• [x] Sort model/federation list alphabetically
• [x] Profile shows model owner not who is logged in
• [x] Issues: Allow only deleting the last comment, no editing
• [x] Issues: Add None to assign list
• [x] Rename model not working in settings
• [x] Issues: Disable screenshot button if issue closed or viewer permission only
• [x] Cancelling Edit federation dialog updates UI
• [x] The prompt re submodel permissions shows up when you are trying to unassign a user
• [x] On Model Permissions page, if the project is empty, it is waiting for models forever
• [x] Typos on signUp and Teamspace page

Jozef's Bugs

• [x] Helicopter icon slow to load
• [x] New comment field should be sticky at the bottom
• [x] Search icon should not be inside an issue

Not Fixing

• [ ] User list order is non deterministic
• [ ] Show user's job next to username in Permissions page

[carmenfan]

Billings page hangs forever unless you load the license page first

• Log in , go to billings page, it will hang forever:
• You can only get it to load if you go to license page first then go back to billings page:

[carmenfan]

Being a Teamspace admin no longer automatically make you a project admin Carmen and James are teamspace admins:

They should be project admins for every projects as well, with every check box disabled so user cannot alter them:

Should also make sure that:

• someone is assigned an admin, these boxes should populate themselves without refreshing
• when someone is revoked from the admin permission, all those disabled check boxes should be unchecked without refreshing

[carmenfan]

Only teamspace owner is being automatically assigned as model admins James is also a teamspace admin, but he's not defaulted as a model admin

Also, while the line for carmen looks disabled, the user can actually change the permission (even though the changes are not reflected upon refreshing):

We should also make sure that project admins are auto model admins for their project

[carmenfan]

Paypal button is missing on the billings page What it looks like in production:

What it looks like on dev:

[carmenfan]

Permissions still need cleaning up

There is Create/Delete federation, but only Create model. At the very least these should match, either have both Create/Delete Federation and Create/Delete Model, or just have "Manage Federation" and "Manage Model". Pavol is in favour of just having Manage *.

We can remove the edit Project from selection really, that only lets you change the name of the project.

[carmenfan]

Error message doesn't disappear when error is rectified Trying to create federation with same name, gives error message which is good-

When I changed it to a valid name, the save button is enabled, but message doesn't disappear:

[carmenfan]

Default units are not consistent between models and federations For new model it currently has cm as default units But federation has milimetres

cm isn't really widely used as a units for AEC models, and pavol thinks it's best if we default to mm.

[carmenfan]

Please Check Input???

This stays there until the user has completed every compulsary field. I can see what you're saying is that the user hasn't completed all required fields, but it doesn't really make much sense to the user. There is probably a better way to do this

[JamesLMilner]

Fixed the PayPal / Billings page issue. Will take a look at the others when I have a moment :smiley_cat:

[carmenfan]

Thanks James, I haven't found anything that is really breaking (apart from unable to pay i guess, but i doubt pavol would test that) so it's probably in a good enough state for user testings.

You're on holiday! take it easy!

[carmenfan]

As a project admin I'm not getting permission on the side menu for models I'm a project admin of henry's, I can change model permissions through the assign permissions tab, but I can't go straight to that tab with the side menu on the model lines

[carmenfan]

Pin should take precedence over measuring tool With both pin and measuring tool enabled, measuring tool functionality is on but pin is off. It should be the other way round.

[carmenfan]

Bugs around multi-select

• When in multi-select mode, clicking on an already highlighted object should only un-highlight that specific object, it is currently un-highlighting everything.
• highlight several objects -> click on the + to create new issue -> all the highlighting is reset (doesnt' happen if it's single object highlighted)
• When in multi-select mode, clicking on backgruond should not reset highlight (should only reset if ctrl isn't pressed) - i think. will double check with pavol

[carmenfan]

Bugs when you load an earlier revision Load a model, then load an earlier revision of the model: The older revision looks like this:

• Model settings aren't loaded/processed properly as the IFC spaces are showing
• cannot highlight the object/fetch metadata

[carmenfan]

Page doesn't hook up to the chat server upon refresh

• Load a medium size model
• refresh the page once it's reached the processing page
• You can no longer see the processing icon, but upload has not finished. (i.e. it's not hooking back up to the chat server, or at least not acting like it has)

[carmenfan]

2 letter model names are invalid but it's not obvious If you name your model with only 2 letters, it's not immediately obvious as to why it's highlighting it as invalid

In fact I never understood why Pinakin decided it has to have a min. of 3 letters. and why it's restricted to hyphen/underscores only. Esp with the new model ID change the user can pretty much have whatever they want as model name.

[carmenfan]

Forgot password page still doesn't work Shows the login page if you click into forgot password:

If you hit refresh it shows up below the login tab:

[carmenfan]

Occasionally components + viewer doesn't load Go into a model:

Keep refreshing, occasionally, the left buttons and viewer doesn't load:

[carmenfan]

Invalid Revision name when it looks valid Removing a few characters worked, so there is probably an implicit character limit.

1. we should give a different error message, or tell the user the max. number of characters just like how we tell them what are the valid characters
2. There's no reason why it has to be so short. we need to extend the length as the real user needs it quite a bit longer (talk to andrew/pavol to check what should be the max length)
3. It should allow hyphens (actually any ASCII characters, but hypens at a minimum)

[carmenfan]

multiple API calls before upload This is not a bug as such but I'm not really understanding what it is doing or why does it need to do that.

When you upload to an existing model, it does an http get on revisions.json and account.json. And I don't see why they need any of that.

The full URLis as follows:

• https://dev.3drepo.io/api/carmen/[object%20Object]/revisions.json -> returns an empty array, doesn't look like a valid call either way.
• https://dev.3drepo.io/api/carmen.json -> which we have the info already, this is done before the upload call so it's unlikely to be any different

It then eventually calls upload.

[carmenfan]

Import failure message is stopping user from viewing the previous revision of the model

The error message doesn't go away and even though there's a working revision for the project, I can't click on it (I can only view the previous revision through the revision list).

It makes sense to be there to notify the user that the last error failed, but we need a way for it to go away and let you get on with things. Alternatively, stick to the way it is working in production - the error message flashes up for a few seconds then it disappear.

[JamesLMilner]

@carmenfan that issue is to do with the frontend checking for a Timestamp which is null on that model for one reason or another. I improved the UX a little around the uploads now though

[paloknapo]

Can't delete model. Error: Internal Error

[paloknapo]

Users deleted with GUI appear in Teamspace Permissions

[paloknapo]

Allow taking screenshot in an issue before typing comment

The button is disabled until a comment is added. User should be able to take screenshot first and then comment. Or vice versa. Display message in bottom toolbar to type something if user hasn't done so before submitting comment

[paloknapo]

Can't deselect multi-selected objects or select other objects when created new issue

Deselect works once back in list view. Also, sometimes object selection saved with issue doesn't work when issue is opened (ie. https://dev.3drepo.io/pavol/e7fe9e98-7120-4c03-aa6b-fbcfde4c27ef/issues/1594df40-8e2d-11e7-895e-9fc113649c02 )

[paloknapo]

3D Viewer jerks when one card is opened and opening or closing the second card

[paloknapo]

User Teamspace expanded by default

Expand user's own Teamspace - Models and Federation. Shared Teamspaces are collapsed. This is what users sees when logs in:

[paloknapo]

Deactivate measuring tool when leaving model

Measuring tool is still active even though I left model and I'm back to Teamspace:

[paloknapo]

Upload dialog doesn't go away when I hit UPLOAD button

Upload starts but I have to click X to get rid of the revision dialog

[paloknapo]

Make "New Comment" in issue clickable

Same as "Description" when creating issue.

[paloknapo]

Missing reset password page

Reset password email link goes to login instead of reset password page

[paloknapo]

Selected objects not saved with issue

Selection is cleared once hit + issue button. When object is selected after issue was created it is still not saved with issue.

[paloknapo]

Issues filter reset doesn't show all issues

When the filter field is empty or reset with the X button list of all issues should appear in the card. This is not happening.

[paloknapo]

Jobs list multiplied in issues menu in federation

Jobs list is taken from each model which is wrong. Jobs list is on teamspace level and it is the same for any model or federation within.

[JamesLMilner]

Revisions sometimes fail to load

When changing between revisions, occasionally they will fail to load

[carmenfan]

Partial failures are being shown as Failed to import once refreshed

Import something with a partial failure (missing nodes, missing textures etc). Once it's imported it's showing the right message (Model in question: test_viewer_change):

But if you refresh the page, it shows Failed to import model:

Which isn't true , as it's technically a success with warning (there is a new viewable revision in the model). Ideally we should display the original error message, or just no message at all. As it stands it's pretty misleading to users, especially if they closed the browser and have never seen the original message just thinks the upload failed.

I'm not sure if the backend gives you the recorded error message to the frontend, maybe what we need is a different status for partial success so you can identify the difference. The error message and status are saved into model settings in backend/models/helper/model.js (function: importModel()) if you need to alter anything there. Technically you just have to display the error reason that is saved into the model settings.

(Pavol should be able to give you texture model to test this)

[paloknapo]

Show resolved issues doesn't work

Issues menu option Show resolved issues doesn't show closed issues.

[paloknapo]

Loading wheel never goes away from the Licences page

[paloknapo]

Unassigned Models message is not true

For example, user andrew is assigned as collaborator or commenter on all sub-models but this message still pops up:

[paloknapo]

Select Models/Federation pop up too short

Make the pop up as large as possible if the list of models, federations is long

[paloknapo]

Print issues not working

I get this error: {"path":"/home/node/3drepo.io/pug/issues.pug","place":"GET /CWCL/04d9ee15-a2af-4ca8-984c-43077c1b42de/issues.html","status":500,"message":"Internal Error","value":4000}

[paloknapo]

Can't select some objects

There are objects in model I can't select in 3D viewer, I can select them in tree though and rest of the model is fine. Here are few examples:

https://dev.3drepo.io/pavol/e7fe9e98-7120-4c03-aa6b-fbcfde4c27ef/issues/5dce5c80-992e-11e7-87da-afdd3d0877da

https://dev.3drepo.io/Laika0901/7640d04e-babf-47d1-9682-c556f78a4d44/issues/c99c2ec0-9932-11e7-8c75-1dad5c71d14f

[paloknapo]

Make Admin radio buttons in models/federations permissions gray

Inactive radio buttons should be gray, RGB = 140, 140, 140

[paloknapo]

Show user's job next to username in Permissions page

[paloknapo]

Sort model/federation list alphabetically

[paloknapo]

Profile shows model owner not who is logged in

[paloknapo]

Issues: Allow only deleting the last comment, no editing

Allow user to delete comment made just now. If someone commented after deleting is not possible. Should work as undo when sending email.

[paloknapo]

Issues: Add None to assign list

For case when user selects a job and decides to un-assign the issue.

[paloknapo]

Issues: Pins of closed issues don't disappear

Pin should disappear from the model if the issue is closed. Pin appears if "Show resolved issues" from issues menu is active.