Issue 639 - Federation group support - Githubissues

3drepo / 3drepobouncer

A C++ library providing 3D Repo Scene Graph definition, repository management logic and manipulation logic. It is is essentially the refactored 3DRepoCore and (parts of) 3DRepoGUI

GNU Affero General Public License v3.0

29 stars 13 forks source link

Issue 639 - Federation group support #642

Closed carmenfan closed 11 months ago

carmenfan commented 1 year ago

This fixes #639

Description

This issue is to change the federation scene graph to match what we have proposed in https://github.com/3drepo/3drepo.io/issues/4391:

Removed the parent transformation before a ref node (it's always an identity matrix due to the way we create federation)
Instead, take in a set of reference nodes and its group name (if any)
turn group name into parenting transformation nodes, if there is none, wire the ref node to the root node.

Test cases

Should continue to produce working federations
Should be able to create groupings to group submodels under the same branch
Submodel references should be wired to the root node they do not belong in a grouping.