3drepo / 3drepobouncer

A C++ library providing 3D Repo Scene Graph definition, repository management logic and manipulation logic. It is is essentially the refactored 3DRepoCore and (parts of) 3DRepoGUI
GNU Affero General Public License v3.0
29 stars 13 forks source link

We're going one level too deep on Native navis import (revit source) #665

Closed carmenfan closed 8 months ago

carmenfan commented 9 months ago

Description

Found whilst testing https://github.com/3drepo/3drepo.io/issues/4552

On a naviswork file with a single rvt file as source, if we compare the tree structure we'll see that we're getting one extra level from the native upload:

image

image

This is an issue as we are getting a different revit ID on the attribute data - which means groups created in native navis import is storing the wrong element ID, thus cross revision function introduced in https://github.com/3drepo/3drepo.io/issues/4552 does not work properly.

image image

As suspected, we're taking the instance reference on as a node in the tree, instead of stopping at the composite object (navis tree icon reference here): image

Steps to replicate

Current Behaviour

Expected Behaviour