search

3drepo / 3drepobouncer

A C++ library providing 3D Repo Scene Graph definition, repository management logic and manipulation logic. It is is essentially the refactored 3DRepoCore and (parts of) 3DRepoGUI
GNU Affero General Public License v3.0
29 stars 13 forks source link

ISSUE #515 FBX rotated on axis #668

Closed vmavadiya closed 8 months ago

vmavadiya commented 8 months ago

This fixes #515

Description

Assimp supported model file rotation is done by file model convertor available in global settings. We need to upgrade assimp library to at least 5.X.X version for fetching "GlobalSetting" from assimp file. I have done with following assimp branch https://github.com/assimp/assimp/tree/v5.3.1

vmavadiya commented 8 months ago

@vmavadiya can you figure out when this is fixed and try a earlier version of assimp?

It's utilisiin string_view which is supported in c++17.

we're still building with c++14 support and upgrading to c++17 is going to be a massive project as some of our other dependencies doesn't like that. So It'd be useful to figure out how far back we can go until vc140/c++14 compiles.

@carmenfan The issue was resolved in 5.x.x version with following commit in assimp https://github.com/assimp/assimp/pull/2293.

And we have used version 5.0.0 of assimp, which is complied with C++14 and working fine.